stacklok / toolhive / 24718401480

66%

Build Type

push

github

Committed by web-flow

Commit Message

Add registry-aware workload creation (#4872)

* Add registry-aware workload creation

Add optional registry and server fields to POST /api/v1beta/workloads
so clients can create workloads by referencing a registry server:

  {"registry": "default", "server": "io.github.stacklok/fetch"}

thv resolves the server from the registry, extracts image/transport/
env vars/permissions/etc from metadata, and builds the RunConfig
server-side. User-provided fields always override registry defaults.

This eliminates client-side field extraction — Studio goes from
GET+extract+POST to just POST.

Ref: #4199

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate OpenAPI spec for registry-aware workload fields

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review findings for registry-aware workload creation

- Fix handler validation: accept registry+server as alternative to
  image/url (was rejecting before resolution could run)
- Fix validation ordering: check registry+server pairing before
  attempting resolution
- Validate registry name: only "default" is currently supported,
  reject unknown values with clear error
- Regenerate OpenAPI spec

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Preserve registry metadata through BuildFullRunConfig

Return ServerMetadata from resolveRegistryServer and assign it to
the local serverMetadata/imageMetadata variables so downstream code
(registry info on RunConfig, tool validation, remote auth config,
proxy port) has access to it.

Skip the imageRetriever re-lookup when metadata was already resolved
from a registry reference — re-looking up by bare image ref would
fail since the image ref doesn't match any server name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Complete remote server metadata handling and address review feedback

Fix remote server path to get the same treatment as image servers:
- Extract ProxyP... (continued)

Coverage Stats

104 of 158 new or added lines in 3 files covered. (65.82%)

8 existing lines in 3 files now uncovered.

58403 of 87889 relevant lines covered (66.45%)

62.55 hits per line