databendlabs / openraft / 24718144418

91%

main: 87%

Build Type

push

github

Committed by drmingdrmer

Commit Message

Fix: gate io-state snapshot update on engine snapshot advancement

Two back-to-back `Raft::trigger().snapshot()` calls at the same
`last_applied` tripped `debug_assert!(log_id > self.snapshot)` in
`IOState::update_snapshot`. The duplicate build completes,
`SnapshotHandler::update_snapshot` returns `false` (no advancement),
but `raft_core` was calling `IOState::update_snapshot` unconditionally
with the equal log id.

Propagate the existing `bool` from `SnapshotHandler::update_snapshot`
out of `Engine::finish_building_snapshot` and only update the io-state
snapshot cursor when the engine actually advanced. The strict `>`
invariant in `IOState::update_snapshot` is preserved — the caller now
honors the information the handler already returns.

Changes:
- `Engine::finish_building_snapshot` returns `bool` (was `()`).
- `raft_core.rs` BuildSnapshot handler gates `io_state.update_snapshot`
  on the returned bool.

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

9717 of 10734 relevant lines covered (90.53%)

7840.88 hits per line