project-slippi / slippi-js / 24711905276

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix: winner calculation to consider when both players have no stocks on the last frame (#165)

* checks if both players have 0 stocks in the last frame, return []

* redoes logic to detect ties soley on final frame state

* test: add placement test for same frame death

* refactor: use last frame when determining winners without game end

* test: add tests for getWinners without game end block

* refactor: generalize last frame placement logic for non 2 player games

* refactor: getWinners with more comments

* refactor: get game end after we confirm game settings

---------

Co-authored-by: Vince <vinceau09@gmail.com>

Coverage Stats

734 of 984 branches covered (74.59%)

Branch coverage included in aggregate %.

48 of 59 new or added lines in 2 files covered. (81.36%)

2 existing lines in 2 files now uncovered.

1889 of 2262 relevant lines covered (83.51%)

148298.49 hits per line