Tatsh / niquests-cache / 24710180881

100%

push

github

session: skip caching streamed responses with unconsumed body

A streamed response (stream=True) whose body the caller has not yet
read cannot be cached: in async mode resp.content is still a coroutine
at that point, so materialising the cache entry would bind an unresolved
coroutine into the backend. Guard _should_store() with a check on
_content_consumed to return False early for such responses.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

56 of 56 branches covered (100.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

486 of 486 relevant lines covered (100.0%)

5.0 hits per line