DeRuina / timberjack / 24707358190

87%

Build Type

push

github

Committed by web-flow

Commit Message

fix: atomic compress write and content-based backup assertions to eliminate race failures (#97)

Three tests failed under `go test -race -count=1 -p 1 ./...` (job 72259765007):

1. TestZstdCompression_SizeRotate_DefaultNaming / _AppendAfterExt
   Root cause: compressLogFile wrote directly to the final .zst/.gz path, so the
   file could be observed by the test (waitForFileWithSuffix) while still being
   written, yielding empty content.
   Fix: write to a temp file (dst+".tmp"), then atomically rename to dst, so the
   compressed file only becomes visible once fully written.

2. TestRotateAtMinutes (and defensively TestRotateAt)
   Root cause: the scheduled rotation goroutine reads nowFn() (= fakeTime()) at
   an indeterminate time relative to when the test advances fakeCurrentTime. Under
   the race detector the goroutine can read the already-advanced fake time and fire
   its real-time timer with ~0 duration, causing rotation to happen at a different
   fake timestamp than the one backupFileWithReason() predicts.
   Fix: replace exact-filename assertions with findBackupFileWithContent(), a new
   helper that scans the directory for a backup file matching the expected reason
   suffix AND content, independent of the timestamp in the filename."

Agent-Logs-Url: https://github.com/DeRuina/timberjack/sessions/b764c9a6-eb88-43dc-9dc0-c46f0bc2bba0

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DeRuina <81315494+DeRuina@users.noreply.github.com>

Coverage Stats

7 of 16 new or added lines in 1 file covered. (43.75%)

1 existing line in 1 file now uncovered.

738 of 830 relevant lines covered (88.92%)

41.29 hits per line