Qiskit / qiskit / 24679584739

88%

Build Type

push

github

Committed by web-flow

Commit Message

fix: PI format for rust Circuit display (#15917)

* fix: added a intermediate function format_float_pi to find closet pi ratio up to a certain limit. also added relative tests named as test_pi_float_format. files modified :crates/circuit/src/circuit_drawer.rs .This concerns the issue #15849

* fix: changed the code according to the comments left. Added more parameters to the function to copy the use of pi_check. Added the possibility of choosing a specific format. Next step is to add the features to support other format.

* fix: moved the function format_float_pi to its own file 'py_check.rs' for better reading. Added support of formats according to the original py_check.py. Added tests for the rust function. Modified the lib.rs to be able to use the function accross files.

* fixe: moved the function to circuit_drawer.rs as asked. Added test to the same file. Removed function parameters as asked and modified output to only have text format

* fix: forgot to remove py_check.rs

* fix: added the fix needed. Merged checks 5 and 6. Rewrite test part into an array for better reading.

* fix: forgot a '}'. Ran all tests

* Apply minor touch-ups to comments and tests

---------

Co-authored-by: OnyxBrumeSky <cowbeez@MacBook-Pro-de-CowBeez.local>
Co-authored-by: OnyxBrumeSky <cowbeez@f6r14s10.clusters.42paris.fr>
Co-authored-by: OnyxBrumeSky <cowbeez@f6r14s14.clusters.42paris.fr>
Co-authored-by: Eli Arbel <arbel@il.ibm.com>

Coverage Stats

101 of 101 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

104681 of 119656 relevant lines covered (87.48%)

980896.02 hits per line