dunglas / go-urlpattern / 24678693572

92%

main: 92%

Pull #11

github

chore: address remaining golangci-lint findings and enforce them

Expand the enabled linter set in .golangci.yml (err113, goconst,
gocritic, intrange, modernize, perfsprint, thelper, unconvert, unparam,
wastedassign, whitespace) and address every new finding:

- wastedassign: collapse ExecInit's 8 dead var = "" initializations and
  one in parser.go where regexpValue was assigned and immediately
  reassigned.
- gocritic (assignOp / ifElseChain / typeSwitchVar): use x += y, rewrite
  if-else chains to switch, switch on typed values.
- intrange: for range b.N in benchmarks, for i := range len(portValue)
  in the port prefix check; keep escape.go as-is (i needed after loop)
  with a //nolint rationale.
- modernize: replace interface{} with any in tests, use slices.Contains.
- perfsprint: fmt.Sprintf("%d", i) -> strconv.Itoa(i) in test names.
- unconvert: drop redundant int() around p.componentStart.
- unparam: consumeRequiredToken no longer returns its *token since
  every caller discarded it.
- whitespace: trim a stray trailing newline in buildExpected and a
  leading one in newExpectedResult.
- err113: hoist "invalid hostname" to errInvalidHostname at package
  level, add two test-only sentinels for the WPT harness.
- goconst: extract "pattern"/"url" into initTypePattern / initTypeURL.
- thelper: t.Helper() in the three WPT test helpers.
- Drop the dead commented //p.result.Hash/Search lines in the
  constructor parser and refactor the surrounding if/else into a switch.

All 365 WPT cases + the regression tests still pass; golangci-lint
reports 0 issues with the widened configuration.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

64 of 71 new or added lines in 6 files covered. (90.14%)

1482 of 1613 relevant lines covered (91.88%)

1131.99 hits per line