ArduPilot / MethodicConfigurator / 24668920022

96%

push

github

fix(params): mark test executable and catch float(result) conversion errors

Two follow-up fixes on top of the ConfigurationStepEvalError refactor:

- Set the executable bit on tests/test_data_model_safe_evaluator.py so
  ruff stops failing with EXE001 (shebang present but file not
  executable). The file was created with a shebang matching other
  tests; only the git mode bit was missing.

- Extend the outer except in compute_parameters to also catch
  ValueError and TypeError. The Par(float(result), ...) call on the
  non-eval path can raise either when result is a string that came
  from a values/Bitmask lookup but is not numerically convertible, or
  when the dict lookup returned an unexpected type. Without these,
  conversion errors escaped both try blocks and could abort the
  configuration-step load. SyntaxError, NameError, KeyError, and
  StopIteration remain for defensive coverage of the surrounding
  code paths.

Signed-off-by: Yash Goel <yashvardhan664@gmail.com>

1797 of 1859 branches covered (96.66%)

11566 of 12271 relevant lines covered (94.25%)

3.72 hits per line