dunglas / go-urlpattern / 24667373104

92%

push

github

perf: cache special-scheme flag and switch scheme checks to map lookups

- Call protocolComponentMatchesSpecialScheme() once per New() and reuse
  the result for both the hostname and pathname branches instead of
  matching the component regex against the five special schemes twice.
- Replace specialSchemeList with a single map[string]struct{} (renamed
  to specialSchemeSet since the value is now a set, not an ordered list)
  so the per-component lookups in processHostnameForInit and
  processPathnameForInit are O(1). protocolComponentMatchesSpecialScheme
  just iterates the map keys, since order is irrelevant when the loop
  returns on the first hit.
- Collapse the port-defaulting loop into a direct DefaultPorts lookup
  gated on specialSchemeSet membership, so user-added DefaultPorts
  entries cannot silently trigger special-scheme behaviour. The
  processedInit protocol is lowercased before the check because in
  "pattern" mode processProtocolForInit does not canonicalize, and the
  protocol component is later compiled with canonicalizeProtocol which
  lowercases — so a mixed-case literal like "HTTP" should behave as
  "http" for port defaulting.

~5-10%% reduction in ns/op on New() across pattern benchmarks.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

20 of 20 new or added lines in 1 file covered. (100.0%)

1502 of 1635 relevant lines covered (91.87%)

1122.56 hits per line