dunglas / go-urlpattern / 24663595320

92%

main: 92%

Build Type

Pull #7

github

Committed by dunglas

Commit Message

perf: cache special-scheme flag and switch scheme checks to map lookups

- Call protocolComponentMatchesSpecialScheme() once per New() and reuse
  the result for both the hostname and pathname branches instead of
  matching the component regex against the five special schemes twice.
- Replace specialSchemeList with a single map[string]struct{} so the
  per-component lookups in processHostnameForInit and processPathnameForInit
  are O(1). protocolComponentMatchesSpecialScheme just iterates the map
  keys, since order is irrelevant when the loop returns on the first hit.
- Collapse the port-defaulting loop into a direct DefaultPorts lookup,
  which already keys the same five schemes.

~5-10%% reduction in ns/op on New() across pattern benchmarks.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #7: perf: cache special-scheme flag and use a map for scheme lookups

Coverage Stats

14 of 14 new or added lines in 1 file covered. (100.0%)

25 existing lines in 1 file now uncovered.

1496 of 1629 relevant lines covered (91.84%)

1125.4 hits per line