tarantool / tarantool / 24653978358

88%

push

github

msgpack: do not validate MP_ARROW payload in mp_check

During replication the MP_ARROW payload is decoded twice by the applier:
 1. applier_read_tx_row() -> xrow_decode() -> mp_check()
 2. applier_thread_reader_f() -> applier_thread_decode_arrow_ipc()

It is too costly and doesn't make any sense. According to flamegraphs a
single arrow_ipc_decode() takes as much time as execute_batch_insert().
This patch removes the first decoding from mp_check(). The only visible
side effect is that require('msgpack').decode() will no longer validate
the Arrow payload. But currently we do not support Arrow in Lua anyway.

Needed for tarantool/tarantool-ee#1710

NO_DOC=ee
NO_TEST=ee
NO_CHANGELOG=ee

70736 of 119006 branches covered (59.44%)

106386 of 121302 relevant lines covered (87.7%)

1358734.38 hits per line