kubeovn / kube-ovn / 24652987962

25%

push

github

feat(qos): support configurable ingress/egress burst via annotation (#6628)

* feat(qos): support configurable ingress/egress burst via annotation

Today the OVS-level ingress policer uses a hardcoded burst of rate*80%
and the linux-htb egress queue does not set burst at all, leaving
users no way to tune the burst budget. Introduce two new pod/node
annotations (and provider-scoped templates) carrying the burst value
in Mbit:

  ovn.kubernetes.io/ingress_burst
  ovn.kubernetes.io/egress_burst

An empty value preserves the historical default (80% of rate); an
explicit "0" is honored as-is (strict shaping with no burst). The
values flow through the existing OVS local path: ingress uses
ingress_policing_burst (kbit) and egress writes the linux-htb queue's
other_config:burst (bytes), with the conversion encapsulated in two
small helpers.

Wire the annotations through all daemon reconciliation paths: CNI
add (veth/sriov/dpdk), pod reconcile for the main and multus
attachment networks, and the node gateway. enqueueUpdatePod now
watches the burst annotations so live updates are picked up without
waiting for an unrelated change. Add validator + unit tests.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(qos): address review feedback on burst handling

- Validator now scans every annotation key ending in
  .kubernetes.io/{ingress,egress}_burst, so provider-scoped burst
  annotations on multus attachment networks are validated alongside the
  unscoped ones (Copilot review on validator.go).
- computeIngressPolicingBurstKbit and computeHtbBurstBytes short-circuit
  to 0 when the rate is non-positive, keeping rate and burst consistent
  with the pre-existing behavior (Copilot review on ovs-vsctl_linux.go).
- Both helpers now log and fall back to the default when the burst
  string fails to parse, so a typo (e.g. "10m") on a node or ... (continued)

47 of 78 new or added lines in 7 files covered. (60.26%)

14014 of 56569 relevant lines covered (24.77%)

0.29 hits per line