valkyrjaio / valkyrja-php / 24648724889

100%

push

github

[Application] Refactor Config to explicit interfaces (#767)

# Description

Refactors the config system away from class inheritance toward explicit
interfaces. Introduces `CliConfigContract`, `HttpConfigContract`, and
`ConfigContract` under `Application\Data\Contract`. Renames all generic
`ConfigContract` files across CLI and HTTP components to
component-prefixed names (e.g. `CliInteractionConfigContract`,
`CliRoutingConfigContract`) for clarity and to avoid naming collisions.
Removes the now-redundant `Cli\Middleware` and `Http\Middleware` config
contracts.

## Types of changes

- [X] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [X] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Application\Data\Contract\ConfigContract`** — added; base
application config interface
- **`Application\Data\Contract\CliConfigContract`** — added; interface
for CLI application config
- **`Application\Data\Contract\HttpConfigContract`** — added; interface
for HTTP application config
- **`CliConfig`** — changed from extending `Config` to implementing
`CliConfigContract`
- **`Cli\Interaction\Data\Config`** →
**`Cli\Interaction\Data\CliInteractionConfig`** — renamed; contract
renamed to `CliInteractionConfigContract`
- **`Cli\Routing\Data\Contract\ConfigContract`** →
**`Cli\Routing\Data\Contract\CliRoutingConfigContract`** — renamed
- **`Cli\Server\Data\Contract\*ConfigContract`** — renamed with explicit
`Cli` prefix throughout
- **`Cli\Middleware\Data\Contract\ConfigContract`** — removed
- **`Http\Middleware\Data\Contract\ConfigContract`** — removed
- **`.github/ci/psalm/psalm.xml`** — suppressed `NoInterfaceProperties`
for property hooks support

> [!WARNING]
> This is a breaking change. ... (continued)

65 of 65 new or added lines in 14 files covered. (100.0%)

13040 of 13040 relevant lines covered (100.0%)

16.01 hits per line