ben-manes / caffeine / #5397

100%

master: 100%

push

github

Cover remaining JaCoCo branches in refresh/remap no-op guards

Three defensive branches in BoundedLocalCache were uncovered because
their preconditions can't arise through the normal refresh protocol:

  1. In the refresh completion lambda, the `removed && (currentValue
     == oldValue)` guard at L1401 never sees `removed==true` with a
     mismatched currentValue — concurrent writes always drop the
     refresh token under the same CHM bin lock. Exercise it via
     `replace(..., shouldDiscardRefresh=false)` with a different new
     value.

  2. In `remap`, the `preserveTimestamps[0]` no-op short-circuit also
     checks `newValue == oldValue` and `cause == null`. Production
     callers couple the flag to returning `currentValue` with a null
     cause, so those fallback branches are unreachable. Cover them via
     the package-level `compute(..., preserveTimestamps)` interface
     with a pre-set flag and (a) a mismatched return value, (b) an
     expired entry where the lambda returns the captured old value.

3915 of 3922 branches covered (99.82%)

8008 of 8008 relevant lines covered (100.0%)

1.0 hits per line