KarpelesLab / goro / 24647072255

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

closure: IncRef bound \$this, release via HandleDecRef

closure_005 leaks the bound object's destruction because goro's closure
storage didn't count as a reference. In PHP:

    \$a = new A(3);
    \$incer = \$a->getIncer(2);    // captures \$this=\$a
    \$printer = \$a->getPrinter();  // captures \$this=\$a
    unset(\$a);                    // \$a still alive via the closures
    \$incer(); \$printer();         // prints via live \$this
    unset(\$incer); \$printer();    // still alive
    unset(\$printer);              // last ref — __destruct fires HERE

goro destroyed \$a immediately on `unset(\$a)` because ZClosure and
wrappedClosure stored the raw ZObject pointer without calling IncRef.

Fix: at Spawn time, IncRef the captured \$this (both ZClosure and
wrappedClosure paths). Register Closure.H.HandleDecRef, which the
FuncContext cleanup loop calls when a Closure leaves scope, to do the
matching DecRefImplicit.

generatorClosure: handle via its inner ZClosure pointer, same as the
existing HandleInvoke dispatcher.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

1 of 24 new or added lines in 1 file covered. (4.17%)

2 existing lines in 1 file now uncovered.

2189 of 112029 relevant lines covered (1.95%)

70.31 hits per line