spesmilo / electrum / 5561449457647616

65%

master: 66%

Build Type

Pull #10591

CirrusCI

Committed by SomberNight

Commit Message

wallet: make_unsigned_tx: fix base_tx for GUI simple-send batching

fixes regression from https://github.com/spesmilo/electrum/commit/a9f20e4d3 :
For the GUI / manual new tx constructions usecase, the flow relies on `base_tx.add_info_from_wallet(self)` being called before `base_tx_fee = base_tx.get_fee()`.

fixes https://github.com/spesmilo/electrum/issues/10587
maybe fixes https://github.com/spesmilo/electrum/issues/8876
    probably not a full fix: base_tx could have inputs for which add_info_from_wallet is not sufficient

Pull Request Pull Request #10591: wallet: make_unsigned_tx: fix base_tx for GUI simple-send batching

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

24426 of 37666 relevant lines covered (64.85%)

0.65 hits per line