bombsimon / wsl / 24637868809

95%

push

github

Fix `go`/`defer` not inspecting anonymous function bodies (#255)

* Fix go/defer not inspecting anonymous function bodies for shared variables

`checkGo` and `checkDefer` used `maybeCheckExpr` which calls
`identsFromNode` with `skipBlock=true`, skipping any `BlockStmt`
including function literal bodies. This caused `go func() { use(x) }()`
to not recognize `x` as a shared variable, incorrectly flagging it as a
violation even when `x` was declared immediately above.

When the called expression is a `*ast.FuncLit`, route through
`checkCuddlingBlock` with the literal's body list instead, matching the
behavior of block-based checks like `for` and `range`.

Fixes #254

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Inline and remove maybeCheckExpr

Now that checkGo and checkDefer no longer use it, maybeCheckExpr is
only called from checkExprStmt. Inline the logic there and delete the
helper.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

59 of 59 new or added lines in 1 file covered. (100.0%)

1513 of 1602 relevant lines covered (94.44%)

333.16 hits per line