umputun / revdiff / 24636874195

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix(ui): keep cursor on same screen row when paging (#125)

* fix(ui): keep cursor on same screen row when paging

PgDown placed the cursor at the viewport top and PgUp at the bottom, so
PgDown then PgUp did not return to the prior position. Share the existing
half-page helper logic so full-page and half-page both scroll cursor and
viewport by the same amount, preserving the cursor's relative on-screen row.

Related to #124

* fix(ui): keep cursor visible when paging on annotated lines

Extend the page/half-page helpers to treat an annotation-row flip
(diffCursor unchanged but cursorOnAnnotation toggled) as real progress,
and scroll the viewport by the cursor's actual visual delta instead of
the requested row count. Without this, PgDown from a line with an
annotation exited the helper loop immediately on the cursorOnAnnotation
flip, then scrolled the viewport by a full page anyway, pushing the
cursor above the viewport.

Rename the helper parameter from n to rows to match the godoc.

Extend TestModel_PgDownPgUpPreservesRelativeCursorPosition with a
mid-screen subcase (so the relative-row assertion is not degenerate at
screen row 0) and split into subtests with a fresh model per case.
Add TestModel_PgDownKeepsCursorVisibleOnAnnotatedLine to lock in the
visibility invariant.

Related to #124

* test(ui): add wrap-mode subtest for PgDown/PgUp cursor row invariant

Adds a wrap-mode subtest to TestModel_PgDownPgUpPreservesRelativeCursorPosition
with a mix of short and long lines. Verified wrap is active (long lines
occupy 4 visual rows). Locks in the invariant that paging preserves the
cursor's on-screen row when cursorViewportY math spans multi-row wrapped lines.

Addresses Copilot review feedback on PR #125.

Related to #124

Coverage Stats

23 of 23 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

7549 of 8476 relevant lines covered (89.06%)

474.86 hits per line