umputun / revdiff / 24636744033

89%

master: 90%

Build Type

Pull #125

github

Committed by umputun

Commit Message

fix(ui): keep cursor visible when paging on annotated lines

Extend the page/half-page helpers to treat an annotation-row flip
(diffCursor unchanged but cursorOnAnnotation toggled) as real progress,
and scroll the viewport by the cursor's actual visual delta instead of
the requested row count. Without this, PgDown from a line with an
annotation exited the helper loop immediately on the cursorOnAnnotation
flip, then scrolled the viewport by a full page anyway, pushing the
cursor above the viewport.

Rename the helper parameter from n to rows to match the godoc.

Extend TestModel_PgDownPgUpPreservesRelativeCursorPosition with a
mid-screen subcase (so the relative-row assertion is not degenerate at
screen row 0) and split into subtests with a fresh model per case.
Add TestModel_PgDownKeepsCursorVisibleOnAnnotatedLine to lock in the
visibility invariant.

Related to #124

Pull Request Pull Request #125: fix(ui): keep cursor on same screen row when paging

Coverage Stats

23 of 0 new or added lines in 0 files covered. (NaN%)

2 existing lines in 1 file now uncovered.

7549 of 8476 relevant lines covered (89.06%)

462.0 hits per line