KarpelesLab / goro / 24621209195

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

ext/gmp: use MT19937 for gmp_random_* seeded source

Previously gmp_random_seed() seeded Go's legacy math/rand LCG, which
disagrees with both PHP's libgmp and goro's own mt_rand (both MT-based).
Switch to github.com/goark/mt/mt19937 — the same package core/random
uses for mt_rand — so seeded output is at least self-consistent
across the goro RNG surface.

Whether this byte-matches PHP's libgmp for gmp_random_seed.phpt is an
open question; libgmp seeds its own MT state on a different schedule
than the reference MT19937. Drop the test from the skiplist so the
CI tells us definitively — if it still fails, we put it back with a
more precise comment.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

71 existing lines in 1 file now uncovered.

2185 of 111881 relevant lines covered (1.95%)

70.41 hits per line