Alan-Jowett / sonde / 24615722129
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 113
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.859%. Remained the same
24615722129

push

github

web-flow 
fix(pair-ui): restore to node scan when paired; fix back navigation (#761)

* fix(pair-ui): restore to node scan when paired; fix back navigation

When the app restarts with a saved page index of 4 or 5 (Node Provision
or Done), those pages require ephemeral state (selected node address,
provisioning-success context) that cannot survive a restart. Previously
the app restored directly to the provision page with \selectedAddressNode\
null, leaving the user stuck with the Provision button disabled and no
path to BLE scanning.

Additionally, \estore()\ previously pushed only [sentinel, pageN] into
history. Pressing back immediately hit the sentinel, whose handler pushed
a new {page:0} state *without* navigating, keeping the UI frozen on pageN.

Fixes:
- Cap restore target at page 3 (Node Scan) when saved page is 4 or 5
  (PT-1219 AC 4)
- Push all intermediate pages 0..N into history on restore so back
  navigation traverses each step in sequence (PT-1220 AC 3)
- Sentinel handler now calls \
avigator_.goTo(0)\ so the UI actually
  navigates to Welcome when the history floor is hit (PT-1220 AC 2, 3)
- Populate \pairDetails\ in \efreshPairingStatus()\ so the Pairing
  Complete page renders correctly when reached via back navigation after
  a restart
- Add \	ry/finally\ around \_skipPush\ in \estore()\ for safety

Spec changes: PT-1219 AC 4 (new), PT-1220 AC 3 (updated),
T-PT-1219b (extended), T-PT-1220e (new), design doc updated.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(pair-ui): address PR review comments

- Clarify restore() comment: ephemeral-page fallback goes to Node Scan
  when paired, Welcome when unpaired (not always Node Scan)
- Fix PT-1219 AC 4 wording: fall back to page 4 only when prerequisites
  are met (i.e. paired); otherwise fall back to earliest valid page per AC 3
- Restore accidentally dropped T-PT-1221a heading in validation doc

Co-authored-by: ... (continued)

24362 of 30129 relevant lines covered (80.86%)

204.34 hits per line

Jobs
ID Job ID Ran Files Coverage
1 24615722129.1 113
80.86
 GitHub Action Run
Source Files on build 24615722129