decentraland / deployments-to-sqs / 24614796767

90%

main: 90%

Pull #523

github

fix: address review feedback on storage wrapper

- Cap stageToDisk with AbortSignal.timeout to prevent hangs on stalled
  (alive-but-not-producing) S3 streams.
- Use `catch (error: unknown)` with instanceof narrowing for type safety.
- Comment the asRawStream bypass so future maintainers know to wrap it
  if a consumer starts using it.
- Note in the forwarded-methods comment why we prefer explicit `bind`
  over `{ ...inner }` spread.
- Switch afterEach to resetAllMocks so mockResolvedValueOnce queues do
  not leak between tests; re-seed logsMock.getLogger in beforeEach.
- Add a write-failure test for the disk-full path.

28 of 35 branches covered (80.0%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 2 files covered. (100.0%)

200 of 213 relevant lines covered (93.9%)

2.53 hits per line