aio-libs / multidict / 24612615370

96%

push

github

fix format error that leads to segfaults (#1310)

<!-- Thank you for your contribution! -->

## What do these changes do?

This was based off a user-accessible segfault found by @devdanzin. Not
sure how this appeared out of nowhere but my best assumption it could've
been caused by developer fatigue or burn out. The reproducible seen in
this gist here
https://gist.github.com/devdanzin/a36588ae7e2b73f0d85f8a925fb13b3d is
not just limited to 3.14 but also 3.10 (which I have now recently tested
myself) so I've gone ahead and fixed it. Feel free to let me know if
this should somehow be added to pytest although IDK where to put it.
Originally was going to write this off as an ffmpeg fiasco but this does
not seem to be the case. Seems we might have couple of other sneaky bugs
to patch.

Reproducer from the gist brought here for reference
```python
"""Reproducer: multidict _err_cannot_fetch swapped format args — abort.

hashtable.h:1467-1475 passes (name, i) but format expects (i, name).
  %zd receives a char* → prints garbage number
  %s receives an int → dereferences integer as pointer → crash

No special setup required.
Tested: multidict 6.7.1, Python 3.14.
"""
from multidict import MultiDict

class BadItem:
    """Looks like a 2-element sequence but __getitem__ raises."""
    def __len__(self):
        return 2
    def __getitem__(self, i):
        raise RuntimeError("intentional getitem failure")

MultiDict([BadItem()])
# Expected: ValueError with proper error message
# Actual: Aborted (core dumped)
#   Assertion `!_PyErr_Occurred(tstate)' failed. 
```
## Are there changes in behavior for the user?

<!-- Outline any notable behaviour for the end users. -->

## Related issue number
> [!NOTE]
> This does not close this issue as there is still other information
about other bugs that have yet to be patched.

#1306 

<!-- Are there any issues opened that will be resolved by merging this
change? -->
<!-- Remember to prefix with 'Fixes' if it should close the i... (continued)

617 of 617 branches covered (100.0%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 2 files covered. (100.0%)

3880 of 4030 relevant lines covered (96.28%)

1.93 hits per line