bcomnes / domstack / 24610510636

91%

master: 92%

Build Type

Pull #242

github

Committed by bcomnes

Commit Message

wrap PageData.vars getter to include page path in error messages

When a page's vars module throws (syntax error, missing dependency,
runtime error), the vars getter propagated a bare error with no
indication of which page failed. In global.data.js and templates,
this forced users to wrap every .vars access in try/catch and
silently swallow errors, hiding which page was broken.

The getter now catches any error at access time and re-throws with
the page path included in the message, making it easy to locate the
offending page without bisecting a large site.

Pull Request Pull Request #242: Include page path in PageData.vars error messages

Coverage Stats

506 of 643 branches covered (78.69%)

Branch coverage included in aggregate %.

10 of 14 new or added lines in 1 file covered. (71.43%)

1 existing line in 1 file now uncovered.

3806 of 4077 relevant lines covered (93.35%)

74.38 hits per line