babelfish-for-postgresql / babelfish_extensions / 24609502649

77%

push

github

Fix allocation of savepoint_name in correct memory context in pltsql_eval_txn_data (#4730)

pltsql_eval_txn_data uses pstrdup to update savepoint_name, which allocates memory in Current Memory Context (SPI Proc). Since txnStmt lives in CachedPlanQuery context, the savepoint_name becomes a dangling pointer when SPI Proc is destroyed after statement execution. When the cached plan is reused, RollbackToSavepoint reads freed memory via strcmp, which can lead to crashes or incorrect behavior.

Hence we use MemoryContextStrdup with cachedPlanSource->query_context to ensure savepoint_name is allocated in the same context as the plan node.

Task: BABEL-6440

Authored-by: Rucha Kulkarni ruchask@amazon.com

1 of 1 new or added line in 1 file covered. (100.0%)

53343 of 69142 relevant lines covered (77.15%)

626131.51 hits per line