babelfish-for-postgresql / babelfish_extensions / 24609440557

77%

BABEL_6_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix allocation of savepoint_name in correct memory context in pltsql_eval_txn_data (#4731) (#4758)

pltsql_eval_txn_data uses pstrdup to update savepoint_name, which allocates memory in Current Memory Context (SPI Proc). Since txnStmt lives in CachedPlanQuery context, the savepoint_name becomes a dangling pointer when SPI Proc is destroyed after statement execution. When the cached plan is reused, RollbackToSavepoint reads freed memory via strcmp, which can lead to crashes or incorrect behavior.

Hence we use MemoryContextStrdup with cachedPlanSource->query_context to ensure savepoint_name is allocated in the same context as the plan node.

Task: BABEL-6440

Authored-by: Rucha Kulkarni ruchask@amazon.com

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

94 existing lines in 3 files now uncovered.

53115 of 69127 relevant lines covered (76.84%)

617832.88 hits per line