cameri / nostream / 24596837766

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix: properly await worker teardown in integration tests to prevent open handles (#481)

* fix: properly await worker teardown in integration tests to prevent open handles

AfterAll was calling worker.close() with a callback but not awaiting it,
so Cucumber resolved the hook immediately leaving the HTTP server, Redis,
and DB connections open. Node.js would then hang indefinitely waiting for
those handles to close.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: guard Redis disconnect and increase AfterAll timeout

Redis client may not be connected when rate limits are disabled in tests,
causing disconnect() to throw ClientClosedError. Guard with isOpen check.
Also raise AfterAll timeout to 30s to allow server and DB to shut down.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: close all HTTP keep-alive connections before server shutdown

http.Server.close() waits for keep-alive connections to drain naturally,
which can prevent the close callback from ever firing. closeAllConnections()
forces them closed immediately so the server shuts down reliably in CI.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: remove ReplaySubject windowTime to prevent dangling timers after tests

ReplaySubject(2, 1000) schedules recurring setTimeout calls to evict stale
buffered events. These timers outlive the test run and keep Node.js alive
after Cucumber finishes, preventing clean process exit on CI.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: add --force-exit to cucumber to handle unclosed handles after tests

The slidingWindowRateLimiterFactory creates a RedisAdapter singleton that
calls client.connect() on first WebSocket connection and has no teardown
path. --force-exit ensures the process exits cleanly after tests complete
rather than hanging on the open Redis socket.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: explicitly exit after AfterAll cleanup instead of --for... (continued)

Coverage Stats

470 of 1071 branches covered (43.88%)

Branch coverage included in aggregate %.

6 of 8 new or added lines in 2 files covered. (75.0%)

8 existing lines in 2 files now uncovered.

1338 of 2633 relevant lines covered (50.82%)

9.53 hits per line