24591428477

Committed 17 Apr 2026 11:40PM UTC coverage: 21.908% (-0.2%) from 22.061%

Build # 24591428477

Build Type

push

github

Committed by

web-flow

Commit Message

fix: improve profile creation experience (#1036)

* fix: improve profile creation experience

- Add default 'New Profile' name with auto-focus
- Add double-click folder browser for path column
- Add tooltips for Name and Path columns
- Initialize pass and git when creating new profile with new folder
- Add ProfileInit helper class for profile initialization

* fix: snapshot existingProfiles before setProfiles in on_accepted

existingProfiles was captured after setProfiles(getProfiles()) had
already run, so it always contained the new profiles — making
initializeNewProfiles unable to detect any profile as new.

Move the snapshot immediately before setProfiles and remove the
redundant second setProfiles call.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: improve profile creation experience

- Add default 'New Profile' name with auto-focus
- Add double-click folder browser for path column
- Add tooltips for Name and Path columns
- Initialize pass and git when creating new profile with new folder
- Add ProfileInit helper class for profile initialization
- Use sorted profile iteration for deterministic order
- Capture existingProfiles before setProfiles to detect new profiles

* fix: apply CodeRabbit auto-fixes

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

---------

Co-authored-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

Coverage Stats

0 of 36 new or added lines in 2 files covered. (0.0%)

27 existing lines in 3 files now uncovered.

1199 of 5473 relevant lines covered (21.91%)

8.58 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/profileinit.cpp

// SPDX-FileCopyrightText: 2026 Anne Jan Brouwer
// SPDX-License-Identifier: GPL-3.0-or-later

/**
 * @file profileinit.cpp
 * @brief Profile initialization utilities implementation.
 */

#include "profileinit.h"

#include <QDir>

/**
 * @brief Check if a profile path is new (doesn't have .gpg-id yet).
 * @param path The profile path to check.
 * @return true if the path needs initialization.
 */
auto ProfileInit::needsInit(const QString &path) -> bool {
  QDir dir(path);
  if (!dir.exists()) {
    return false;
  }
  return !dir.exists(".gpg-id");
}

1	// SPDX-FileCopyrightText: 2026 Anne Jan Brouwer
2	// SPDX-License-Identifier: GPL-3.0-or-later
3
4	/**
5	* @file profileinit.cpp
6	* @brief Profile initialization utilities implementation.
7	*/
8
9	#include "profileinit.h"
10
11	#include <QDir>
12
13	/**
14	* @brief Check if a profile path is new (doesn't have .gpg-id yet).
15	* @param path The profile path to check.
16	* @return true if the path needs initialization.
17	*/
NEW 18	auto ProfileInit::needsInit(const QString &path) -> bool {	×
NEW 19	QDir dir(path);	×
NEW 20	if (!dir.exists()) {	×
21	return false;
22	}
NEW 23	return !dir.exists(".gpg-id");	×
NEW 24	}	×

IJHack / QtPass / 24591428477

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous