umputun / revdiff / 24581133736

90%

push

github

fix(ui): keep wrap and annotation rows visible at viewport bottom (#118)

syncViewportToCursor compared only the cursor's top row to the viewport
bottom, so when the cursor sat on the last visible row with a logical line
taller than one visual row, the extra rows (wrap continuations under
--wrap, or multi-line annotation rows injected below the diff line)
rendered past the viewport bottom and were clipped.

Introduce cursorVisualRange/cursorVisualHeight to compute the cursor's
full visual extent via the existing hunkLineHeight / wrappedLineCount /
wrappedAnnotationLineCount helpers. syncViewportToCursor now scrolls
against the cursor's visual bottom, with a min(..., cursorTop) floor so
a logical line taller than the viewport keeps the cursor top anchored.
SetContent runs before SetYOffset so viewport.maxYOffset() reflects
post-mutation content length.

Also add syncViewportToCursor() to the editor-finished save path in
saveComment so a freshly saved multi-row annotation scrolls into view
when the cursor sits near the bottom.

Tests cover wrap-overflow, annotation-overflow, cursor-on-annotation
sub-line overflow, file-annotation overflow, cursor-taller-than-viewport
floor, editor-save line-level sync, and editor-save file-level GotoTop.

30 of 32 new or added lines in 2 files covered. (93.75%)

7054 of 7982 relevant lines covered (88.37%)

331.68 hits per line