babelfish-for-postgresql / babelfish_extensions / 24579073114

77%

BABEL_6_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix for Invalid Token Stream error for simple queries in go driver (#4718)

Simple queries like SELECT 1 AS test were failing on go-sqlcmd v1.9.0 with error: Invalid TDS stream: unknown token type returned: token(165) causing the session to hang. This was because TdsSendRowDescription()was sending colinfo token for regular queries. The go-mssqldb driver does not implement a parser for colinfo token, so it reports the token as unknown and the TDS stream becomes desynchronized, causing the session to hang.

Fix: Guarded SendColInfoToken() with if (relMetaDataInfoList != NIL) so it is only sent when table metadata exists. Also, added a no_browsetable check, when NO_BROWSETABLE is ON, the COLINFO token is sent, otherwise it is not sent.

Task: BABEL-6423

Authored by: Vineetha125 bvineets@amazon.com

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

53319 of 69114 relevant lines covered (77.15%)

402102.51 hits per line