redhat-developer / yaml-language-server / 24572672533

85%

master: 80%

Build Type

push

github

Committed by datho7561

Commit Message

fix: skip local sibling probe in _preferLocalBaseForRemoteId for non-file:// schemas

When a schema is loaded from an https:// URL (e.g. via a VS Code YAML
extension contributor), _preferLocalBaseForRemoteId extracts the basename
from sub-schema $id values and probes for them as local siblings. This
causes spurious HTTP requests that fail with 404 errors.

For example, loading openapi.v3.1.yaml (with $id pointing to
github.com/.../schema.yaml) from an https:// contributor causes a probe
for <contributor-base>/schema.yaml, which does not exist.

The companion function _resolveLocalSiblingFromRemoteUri already guards
against this with `if (parentUri.scheme !== 'file') return undefined`.
Apply the same scheme guard to _preferLocalBaseForRemoteId so the local
sibling optimization only fires for file:// schemas where it makes sense.

Made-with: Cursor

Coverage Stats

2998 of 3729 branches covered (80.4%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

4435 of 4985 relevant lines covered (88.97%)

287993.17 hits per line