Eyevinn / moqtransport / 24570600388

51%

main: 50%

Build Type

Pull #10

github

Committed by tobbee

Commit Message

fix(wire): correctly terminate KVP extension-header parsing

parseLengthReader wrapped the input in LimitReader+bufio+quicvarint.Reader and looped forever until the inner readers surfaced an error. At the exact end of the length-prefixed KVP block that error is io.EOF, which was returned as if the parse had failed. The extra buffering also risked reading past the length boundary.

Read the 'length' bytes up front and parse them byte-wise until the buffer is empty. Remove the now-unused KeyValuePair.parseReader and add a TestParseLengthReader regression test covering the end-of-list, empty-list, and trailing-bytes cases.

Pull Request Pull Request #10: fix(wire): correctly terminate KVP extension-header parsing

Coverage Stats

7 of 9 new or added lines in 1 file covered. (77.78%)

19 existing lines in 5 files now uncovered.

2792 of 5513 relevant lines covered (50.64%)

5.6 hits per line