stacklok / toolhive-studio / 24565356636

70%

push

github

test(registry): pin useRegistryUpdateMutation coverage to fix Coveralls flake (#2035)

* test(registry): pin useRegistryUpdateMutation coverage to fix Coveralls flake

Coveralls has been reporting a -0.02% regression on PRs that touch only docs/CI because line 59 of use-registry-update-mutation.ts (the generic `throw e` rethrow inside putRegistry) was only ever hit ambiently via registry-tab.test.tsx. Depending on MSW teardown and test scheduling it sometimes flipped to uncovered, producing a spurious -2.25% delta on this file (~-0.02% total).

Add a direct unit test that exercises every branch of the hook: default/url/local_path happy paths, api_url with full/partial/no auth, OIDC_DISCOVERY and AUTH_FIELDS_REQUIRED error patterns, non-matching PUT errors for both api_url and url types (covers `throw e` from both guard paths), and the authenticateWithRegistry login-failure path (REGISTRY_WRONG_AUTH_TOAST + invalidate + fire-and-forget logout). Verified lcov output is byte-identical across three consecutive coverage runs, with DA:59 pinned at hit-count 3.

* test(registry): strengthen rethrow assertions and await login rejection deterministically

Addresses Copilot review feedback on #2035:
- Pin the exact thrown value in the two rethrow tests so line 59
  (`throw e`) is protected against regressions that would wrap the
  original error in a new Error.
- In the login-failure test, await the mutation promise directly
  (`await expect(promise).rejects.toMatchObject(...)`) instead of the
  side-effecting `.catch` + local variable pattern, so the toast
  assertion no longer races the React Query observer notification.

Made-with: Cursor

3581 of 5980 branches covered (59.88%)

5706 of 8708 relevant lines covered (65.53%)

120.48 hits per line