tari-project / tari / 24561774896
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 702
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.957% (-0.05%) from 61.006%
24561774896

push

github

web-flow 
feat: convert merge mining cucumber tests to RxT (#7747)

Description
---
Convert merge mining integration tests from RandomX-Monero (RxM) to
RandomX-Tari (RxT) by switching from the standalone
`minotari_merge_mining_proxy` to the base node's built-in `xmrig_proxy`.

Key changes:
- **`port_pool.rs`**: Added `xmrig_proxy` port to `BaseNodePorts`;
renamed `merge_mining_proxy_ports` -> `xmrig_proxy_ports`; removed
standalone proxy port allocation methods.
- **`base_node_process.rs`**: Enabled built-in `xmrig_proxy` during base
node spawn (`xmrig_proxy_enabled`, `xmrig_proxy_address`,
`xmrig_proxy_wallet_payment_address`).
- **`merge_mining_proxy.rs`**: Rewrote from external process launcher to
lightweight HTTP client targeting the base node's built-in proxy;
removed all Monero-specific config (`monerod_url`, wallet gRPC); removed
unsupported methods (`get_last_block_header`,
`get_block_header_by_hash`).
- **`merge_mining_steps.rs`**: Updated step definitions for new RxT API
response format (76-byte hex blobs, `submitblock` instead of
`submit_block`, `count` instead of `height`).
- **`MergeMining.feature`**: Removed `@broken` tag; removed Monero
origin submission scenario; adapted validation steps.
- **`BlockExplorerGRPC.feature`**: Removed wallet dependency that was
only needed for the old standalone proxy.
- **`Cargo.toml`**: Removed `minotari_merge_mining_proxy` dependency.
- **`world.rs`**: Updated `after` hook to return `xmrig_proxy` ports to
pool on base node shutdown.

Motivation and Context
---
#7737 

How Has This Been Tested?
---
```bash
cargo test --test cucumber --package tari_integration_tests -- --tags "@merge-mining"
```

Results:
- 2 scenarios passed (Merge Mining Proxy API Test, Simple Merge Mining)
- 12 steps passed
- 0 failures

What process can a PR reviewer use to test or verify this change?
---
1. Run the merge mining integration tests:
   ```bash
cargo test --test cucumber --package tari_integration_tests -- --tags
"@merge-mining"
 ... (continued)

70639 of 115883 relevant lines covered (60.96%)

224319.38 hits per line

Coverage Regressions

Lines Coverage ∆ File
798
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs
621
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
168
0.0
 0.0% base_layer/wallet/src/output_manager_service/handle.rs
88
57.33
 -0.54% comms/dht/src/connectivity/mod.rs
33
0.0
 0.0% applications/minotari_utils/src/commands/dbstats.rs
6
92.14
 -1.27% comms/dht/src/outbound/broadcast.rs
4
61.59
 1.19% comms/core/src/connectivity/manager.rs
2
91.01
 -0.11% base_layer/transaction_components/src/transaction_builder/builder.rs
2
80.19
 -0.48% comms/core/src/connection_manager/peer_connection.rs
2
81.36
 -3.39% comms/core/src/pipeline/outbound.rs
1
66.67
 -0.28% base_layer/core/src/mempool/sync_protocol/mod.rs
1
85.42
 -0.23% base_layer/p2p/src/services/liveness/service.rs
1
94.79
 -1.04% base_layer/transaction_components/src/consensus/consensus_encoding/hashing.rs
1
90.56
 -0.29% comms/core/src/multiplexing/yamux.rs
1
36.36
 -9.09% comms/dht/src/outbound/error.rs
1
33.96
 -1.89% comms/dht/src/outbound/message.rs
Jobs
ID Job ID Ran Files Coverage
1 24561774896.1 702
60.96
 GitHub Action Run
Source Files on build 24561774896