Qiskit / qiskit / 24559580288

87%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix panic in `RemoveIdentityEquivalent` with `ParameterVector` global phase (#16054)

If a circuit has a global phase containing a `ParameterVectorElement`,
the resulting `SymbolExpr` will transitively contain a `Py<PyAny>`
pointing back to the `ParameterVector` object.  When adding to the
global phase, a name/symbol-map clone occurs, which requires us to be
attached to the Python interpreter.  Since `RemoveIdentityEquivalent`
manually detaches from the Python interpreter, we may attempt to
increment the refcount without being attached.

This patch is intended to be minimal for backport to 2.4; there are
several more invasive changes we could make (and largely _should_ make)
to make `ParameterExpression` safer and more performant, and in general
it is becoming clear we still have a lot of work to do to be able to
remove the `py-clone` feature use of PyO3 and let the compiler catch
these mistakes for us.

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

25 existing lines in 3 files now uncovered.

104577 of 119555 relevant lines covered (87.47%)

985697.42 hits per line