Altinity / altinity-mcp / 24557856044

77%

main: 77%

Build Type

push

github

Committed by BorisTyshkevich

Commit Message

Fix tools-management issues from app-team review

1. getArgumentsMap now returns (map, error) instead of silently swallowing
   JSON parse errors. All 5 call sites updated to surface the error to the
   MCP client instead of producing cryptic downstream errors.

2. Add clickhouse.max_query_length (default 10MB) and max_parameter_size
   (default 10MB) limits. Oversize inputs rejected before reaching CH.

3. New truncateErrForClient helper caps error messages sent to clients
   at 2000 chars. Full error still logged server-side. 5 call sites updated.

4. Unit tests for buildInsertQuery (unicode, null bytes, backslash,
   quote escaping, required-param validation, optional-param omission,
   no-columns) and buildDynamicWriteQuery (mode dispatch, unsupported
   mode rejection). New TestRegisterTools_RejectsUnsupportedWriteModes
   covers config-time rejection of update/upsert modes.

5. EnsureDynamicTools now uses RWMutex fast path + TryLock so concurrent
   requests don't block during initial slow discovery — they see static
   tools immediately and get updated via notifications/tools/list_changed
   when discovery completes.

Cleanup:
- Remove dead dynamicToolMeta.IsStatic field
- Reject update/upsert write modes at config-parse time in RegisterTools
  instead of at call time (the tool no longer registers if it can't work)
- Simplify buildDynamicWriteQuery dispatcher (only insert is valid)
- Update TestGetArgumentsMap_ErrorPath to match new error-returning behavior

Declined from review spec:
- 1MB query limit default (too restrictive for OLAP; using 10MB)
- 1000-char error truncation (too aggressive; using 2000)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

50 of 105 new or added lines in 2 files covered. (47.62%)

252 existing lines in 2 files now uncovered.

4361 of 5675 relevant lines covered (76.85%)

1.1 hits per line