databendlabs / openraft / 24551941694

91%

main: 86%

push

github

Fix: allow newer snapshot in `Inflight::Snapshot` ack

A replication snapshot boundary is chosen at `next_send` time from the
engine's cached `snapshot_last_log_id()`, but the state machine can build
a fresher snapshot before `ReplicationCore::stream_snapshot` calls
`get_snapshot()`. When the callback reports the shipped snapshot's actual
`last_log_id`, the old `debug_assert_eq!(&upto, last_log_id)` in
`Inflight::ack` would panic in debug builds, even though the follower
received strictly more data than requested and `matching` advances safely.

Relax the check to `upto >= last_log_id`. This still catches a real
regression — shipping an older snapshot than expected would roll
`matching` backward on the follower — but accepts the benign TOCTOU race.

2 of 2 new or added lines in 1 file covered. (100.0%)

9677 of 10700 relevant lines covered (90.44%)

7770.36 hits per line