babelfish-for-postgresql / babelfish_extensions / 24550159717

78%

push

github

Add MultiPoint datatype support   (#4719)

**Currently**, Babelfish supports `geometry` and `geography` spatial types for `Point`, `LineString`, and `Polygon` geometries. Attempting to use `MultiPoint` geometry type results in an *"unsupported geometry type"* error across all input/output paths including WKT text input, binary (`varbinary`) conversion, and spatial functions like `STGeomFromText` and `STMPointFromText`.

**With this change**, Babelfish now fully supports the **MultiPoint** geometry type for both `geometry` and `geography` data types. Users can create, store, retrieve, convert, and validate MultiPoint geometries through all existing spatial interfaces, matching T-SQLServer behavior.

**Why:** MultiPoint is a fundamental OGC geometry type used in real-world spatial applications to represent collections of discrete point locations (e.g., sensor networks, store locations, sample sites). Supporting it closes a significant gap in spatial type coverage and moves Babelfish closer to full T-SQL spatial compatibility.

**How the code was changed:**

1. **WKT Parser (grammar + rewrite functions):** Added grammar rules for parsing `MULTIPOINT((x y), ...)` and `MULTIPOINT Z/M/ZM(...)` syntax in both parenthesized and bare coordinate formats. Added `rewrite_multipoint_wkt()` and `rewrite_dim_multipoint_wkt()` functions for WKT normalization.

2. **T-SQL CLR Binary ↔ PostGIS WKB conversion (`spatialtypes.c`):**
   - **Bytea → PostGIS (T-SQL input):** Added CLR figure/shape metadata parsing for MultiPoint, validation of `STROKE` figures and `POINT` child shapes, and conversion from CLR columnar coordinate layout to PostGIS WKB MultiPoint format.
   - **PostGIS → Bytea (T-SQL output):** Added de-interleaving of PostGIS per-point WKB into CLR columnar format (XY block, Z block, M block), plus CLR metadata serialization (figures + shapes arrays).

3. **Geography validation:** Added MultiPoint coordinate validation for latitude/longitude range constraints... (continued)

307 of 327 new or added lines in 4 files covered. (93.88%)

53343 of 69142 relevant lines covered (77.15%)

624064.86 hits per line