ArduPilot / MethodicConfigurator / 24541849970

96%

push

github

fix(backend_filesystem): skip 00_default.param when restarting after final step

The vehicle configuration flow writes the current step to
last_uploaded_filename.txt on every step, so when the user completes the
final step (53_everyday_use.param) and relaunches the program, get_start_file
now detects that start_file_index is past the end of the list.

Previously it returned start_file, which resolves to files[0]
(00_default.param) when tcal_available=True. 00_default.param is a read-only
snapshot of the flight controller's factory defaults, not an editable step.
Users reported (#1507) that the UI would then present 00_default.param and
spend a long time loading it.

Keep the tcal_available branching untouched (tcal_available=False already
picks files[2] and must keep doing so), and only walk forward past
00_default.param when start_file itself is that read-only snapshot. Covered
by two new assertions in test_get_start_file_after_final_file_skips_default
-- one for each tcal_available path.

Fixes #1507

Address @amilcarlucas review feedback on #1521:

- Collapse the forward-walk loop into a single-expression next() with
  a typed default so the function drops one return statement (fits the
  project's PLR0911 limit) and makes the 'no non-default file found'
  outcome explicit.
- Raise ValueError instead of silently returning 00_default.param when
  the file list is degenerate (only the read-only factory snapshot).
  The caller is expected to surface this rather than hand the user a
  non-editable file to edit.
- Update test_get_start_file_after_final_file_skips_default to assert
  the new raise behaviour for the degenerate case.

The existing tcal_available=False wraparound path is preserved: keeping
the 'start_file == 00_default.param' gate avoids regressing the
files[2] entry point (first non-tcal editable step).

Signed-off-by: Trevin Chow <trevin@trevinchow.com>

1745 of 1806 branches covered (96.62%)

11441 of 12152 relevant lines covered (94.15%)

3.75 hits per line