dcdpr / jp / 24536510404

66%

Build Type

push

github

Committed by web-flow

Commit Message

feat(llm, mcp): Forward tool and MCP server stderr to tracing (#573)

Tool commands and MCP server processes previously discarded their stderr
output entirely, making it impossible to diagnose failures without
attaching a debugger or wrapping the binary.

Both outputs are now piped and forwarded line-by-line to tracing using
byte-level readers, so non-UTF-8 output doesn't terminate the forwarder.
Tool command stderr is tagged with the invocation's id and name and
emitted under `tool::stderr`; MCP server stderr is tagged with the
server id and emitted under `mcp::stderr`. Users can opt in selectively,
e.g.:

    jp --log=mcp::stderr=trace query "..."
    jp --log=tool::stderr=trace query "..."

To support optional forwarding, `run_tool_command` gains a new
`trace_as: Option<ToolTrace<'_>>` parameter. Passing `None` disables
forwarding (used for argument-formatting invocations where stderr is not
meaningful). `ToolTrace` is also re-exported from `jp_llm`.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

32 of 67 new or added lines in 3 files covered. (47.76%)

173 existing lines in 5 files now uncovered.

22953 of 35725 relevant lines covered (64.25%)

249.93 hits per line