umputun / revdiff / 24535995505

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat(ui): Ctrl+E editor handoff for multi-line annotations (#115)

* docs: add external-editor annotations implementation plan

Plan for adding Ctrl+E / $EDITOR integration to annotation input so
users can write multi-line annotations. Covers multi-line rendering,
editor invocation via tea.ExecProcess, save-on-exit flow, output
format compatibility, and documentation sync.

Related to #111

* feat: multi-line aware annotation rendering

* feat: add editor invocation helpers in app/editor package

Introduce app/editor package with ExternalEditor interface and
temp-file lifecycle management for launching external editors.

* feat: wire Ctrl+E editor handoff into annotation input flow

* feat: multi-line annotation output and list overlay flattening

* docs: document Ctrl+E editor handoff for multi-line annotations

* docs: move external-editor-annotations plan to completed

* fix: address review feedback

Consolidated review fixes from multiple iterations:
- address code review findings on annotation store, editor, and UI
- address iter-2 review findings on annotate flow and docs
- address codex review findings on editor and annotate
- name receiver on annotationContinuationIndent
- don't save seed content on editor launch failure
- document edge case in handleEditorFinished seed comparison

* fix: apply extendLineBg per visual row in renderWrappedAnnotation

* docs: add Architecture Principles section to CLAUDE.md

Captures three principles enforced via course-correction this branch:
decouple OS/external concerns from UI, minimize exported surface,
consumer-side interfaces for external deps.

* fix: address Copilot review findings

- tokenize: narrow backslash escape to shell-meta chars only (POSIX-style);
  preserves Windows-style `C:\foo` paths with backslash intact
- NewModel: guard against typed-nil ExternalEditor via isNilValue helper so
  `(*T)(nil)` defaults to editor.Editor{} instead of panicking on Command
- ARCHITECTURE.md: correct `##` escap... (continued)

Coverage Stats

297 of 320 new or added lines in 7 files covered. (92.81%)

1 existing line in 1 file now uncovered.

6860 of 7699 relevant lines covered (89.1%)

341.09 hits per line