archetech / archon / 24535025637

95%

main: 89%

Build Type

Pull #444

github

Committed by macterra

Commit Message

fix: normalize JSON-serialized Buffer in getImage/getFile

When KeymasterClient receives image or file assets over HTTP, Node's
Buffer.toJSON() serializes the binary data as { type: "Buffer", data: [...] }.
The client was returning this plain object as-is, causing fs.writeFileSync
to throw ERR_INVALID_ARG_TYPE in the CLI's get-asset-image and get-asset-file
commands.

Add normalizeBufferData() helper that reconstitutes the JSON-serialized
Buffer back into a real Buffer instance, and apply it in getImage() and
getFile().

Pull Request Pull Request #444: fix: normalize JSON-serialized Buffer in getImage/getFile

Coverage Stats

1994 of 2213 branches covered (90.1%)

Branch coverage included in aggregate %.

6 of 13 new or added lines in 1 file covered. (46.15%)

7 existing lines in 1 file now uncovered.

4235 of 4356 relevant lines covered (97.22%)

1164.5 hits per line