dcdpr / jp / 24518028459

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(storage): Skip locked conversations during sanitization (#567)

During workspace sanitization, invalid conversation directories are
normally trashed. However, this creates a race condition when two
processes are running concurrently: process A creates a conversation
directory (e.g. for `QUERY_MESSAGE.md` while the editor is open) but
hasn't persisted `metadata.json` yet, and process B's sanitization
deletes it because it looks invalid.

To fix this, a new `is_conversation_locked` method is added to
`Storage`, which returns `true` if a live (non-orphaned) lock file
exists for a given conversation ID. During sanitization, any invalid
conversation directory that is currently locked is skipped with a
`debug`-level log entry instead of being trashed.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

10 of 10 new or added lines in 2 files covered. (100.0%)

141 existing lines in 2 files now uncovered.

22698 of 35356 relevant lines covered (64.2%)

417.09 hits per line