stacklok / toolhive / 24510354959

68%

push

github

Add v0.1 server browse endpoints (#4871)

* Add v0.1 server endpoints and combine registry router

Add upstream-compatible server browse endpoints:
- GET /registry/{name}/v0.1/servers (paginated, searchable)
- GET /registry/{name}/v0.1/servers/{serverName}/versions/latest

Servers are converted from ToolHive types to ServerJSON using
toolhive-core converters. Same pattern as the skills endpoint.

Combine skills and servers into a single RegistryV01Router with
shared helpers (provider accessor, pagination, JSON errors).
Refactor skills handlers to use shared helpers.

Ref: #4199

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate OpenAPI spec for v0.1 server endpoints

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix pagination overflow: parse limit before computing page cap

The page overflow guard was computed against the default limit (50)
before the actual limit from the query string was parsed. This meant
(page-1)*limit could overflow when both a large page and custom
limit were specified. Fix by parsing both page and limit first,
then computing the cap.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review feedback

- Add ErrServerNotFound sentinel and use errors.Is() instead of
  fragile strings.Contains(err.Error(), "not found") pattern
- Wrap server-not-found errors in BaseProvider and APIRegistryProvider
  with the sentinel via fmt.Errorf("%w: ...", ErrServerNotFound, ...)
- Add @Failure 400 Swagger annotation for invalid server name encoding
- Regenerate OpenAPI spec

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

119 of 179 new or added lines in 6 files covered. (66.48%)

57322 of 86848 relevant lines covered (66.0%)

62.73 hits per line