decentraland / profile-images / 24508717107

89%

push

github

feat: skip Godot render when avatar has not changed (#147)

* feat(storage): add retrieveAvatarInfo, storeAvatarInfo, deleteAvatarInfo methods

Add three new methods to IStorageComponent to persist and retrieve the last-rendered
AvatarInfo per entity. Key pattern: ${prefix}/entities/${entityId}/avatar.json.

- retrieveAvatarInfo: returns undefined on NoSuchKey or any S3 error (graceful degradation)
- storeAvatarInfo: non-fatal write; logs warning on failure
- deleteAvatarInfo: non-fatal delete; logs warning on failure

* feat(utils): add avatar-comparison utility for change detection

Pure function avatarsAreVisuallyEqual(a, b) compares visually-relevant AvatarInfo
fields: bodyShape, wearables, forceRender, eye/hair/skin colors.

- Wearables and forceRender compared case-insensitively and order-independently
- Colors rounded to 4 decimal places to avoid float serialization noise
- null/undefined wearables arrays normalized to []

* fix(image-processor): skip Godot render when avatar is unchanged

Implements core-team#200. Before calling Godot, fetch the last-rendered AvatarInfo
from S3 for each entity in the batch and compare visually-relevant fields.

Changes:
- Read stored avatar info in parallel for all batch entities
- Partition entities into needsRender vs skipped using avatarsAreVisuallyEqual
- Skip Godot entirely for unchanged entities; return synthetic success result
- Store rendered AvatarInfo after storeImages succeeds (for future comparisons)
- Delete stored AvatarInfo on Godot failure so DLQ retry always re-renders
- Increment snapshot_generation_count{status=skipped} metric for skipped entities
- Preserve original entity order in returned results

* test: add coverage for change detection and new storage methods

- Update IStorageComponent mocks (in-memory, jest mocks, test/components.ts)
- Add 44 new test cases: avatar-comparison utility, storage methods, image-processor
  change-detection flows (unchanged skip, changed render, mixed bat... (continued)

160 of 205 branches covered (78.05%)

Branch coverage included in aggregate %.

56 of 57 new or added lines in 3 files covered. (98.25%)

483 of 521 relevant lines covered (92.71%)

20.78 hits per line