KarpelesLab / libwallet / 24507709035

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltlog: leveled logging controlled by Info:setWalletInfo's LogLevel

New wltlog package with Debugf / Infof / Warnf / Errorf helpers.
Call sites flip between quiet (release) and verbose (dev) without
recompiling, via Info:setWalletInfo.

LogLevel field added to WalletInfo (Go + Dart):
  ""       → auto — debug on dev binaries (gitTag empty),
             info on release binaries (gitTag set by CI -ldflags)
  "debug"  → everything: per-RPC method+latency, per-decrypt,
             diagnostic state dumps, every self-heal gate
  "info"   → state changes only: wallet loaded, broadcast OK,
             pubkey repair fired, etc.
  "warn"   → warnings + above (pubkey mismatch detected, RPC retry)
  "error"  → errors only
  "off"    → silent

Dart hosts typically pass `kDebugMode ? "debug" : "off"` — or leave
empty and trust the build-type auto-default.

Info:getWalletInfo now also returns `effectiveLogLevel` so the host
doesn't have to recompute the empty→auto resolution itself.

Converted these call sites (previously raw log.Printf):

  * ed25519-repair flow — every skip-reason logs at debug, the
    actual repair at info, save failures at error.
  * solana-send flow — entry / post-repair traces at debug, TSS
    sign latency at debug, local-verify failure at error,
    "broadcast OK" at info.
  * wltnet.DoRPCCtx / DoRPCNamedCtx — per-call method+latency+size
    at debug. Release binaries stay silent; a tester on "debug"
    sees every RPC round-trip.
  * wallet.go subSign (ed25519 branch) — entry, per-key decrypt
    latency at debug, Pubkey-mismatch-detected at warn.

So in release builds the log volume is dominated by the things the
support team would want to see anyway (broadcasts and repairs), and
in a repro-bug session a tester can flip LogLevel="debug" on their
settings screen and get a full trace.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

13 of 160 new or added lines in 7 files covered. (8.13%)

5 existing lines in 2 files now uncovered.

2131 of 10248 relevant lines covered (20.79%)

2.51 hits per line