KarpelesLab / libwallet / 24507186062

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

Solana ed25519 self-heal: diagnostic logs + fix silent short-circuit

Tester on 0.3.11 reports Solana sends still fail and no
"ed25519-repair:" log shows up — meaning the self-heal is not even
firing. Two problems:

1. FindAccount(address)-path skipped check(). tx.From is almost
   always an address (not an xuid), so FindAccount fell through to
   psql.Get by Address, which returned the raw row. check() never
   ran, so Account.Curve could be empty. My guard
     if a.Curve != "ed25519"
   then short-circuited before the decrypt — the repair never
   reached the wallet pubkey comparison. Fix: call acct.check(e)
   at the end of the address-lookup branch; also fall back to
   wallet.Curve inside the helper itself as defense-in-depth.

2. All six early returns in EnsureEd25519PubkeyOnAccount were
   silent. Added log.Printf at each with a specific reason (nil
   account, no wallet, GetEnv nil, WalletById failed, wrong curve,
   no keys, EnsureEd25519Pubkey decrypt failed, empty want, or
   already-correct). Plus one unconditional diagnostic line right
   before the want==a.Pubkey short-circuit that dumps
     want, a.Pubkey, w.Pubkey, a.Address
   so the tester's next "issue persists" report tells us exactly
   which of these is true:
     (a) wallet pubkey is ALREADY correct (not a legacy encoding
         bug — the rejection has a different root cause)
     (b) wallet pubkey is legacy, account was already repaired
         by a prior run
     (c) wallet pubkey is legacy, account Pubkey is legacy, repair
         needed but something upstream prevents it

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 28 new or added lines in 2 files covered. (0.0%)

3 existing lines in 2 files now uncovered.

2119 of 10089 relevant lines covered (21.0%)

2.53 hits per line