dcdpr / jp / 24501507832

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(llm): Fix null rendering and strict-mode nullable schema (#560)

Two related bugs affecting tool call correctness are addressed here.

First, minijinja's default environment renders JSON `null` values as
`none` (Jinja2 convention). When tool arguments containing null fields
were templated into a command via `{{tool}}`, the output was invalid
JSON — `serde_json` would reject it with "expected ident". The fix is to
set `AutoEscape::Json` on the `Environment` used in `run_tool_command`,
which ensures null is serialized as `null`.

Second, `enforce_strict_object_structure` was adding all properties to
`required` for OpenAI strict mode without accounting for properties that
were originally optional. This made the schema invalid because the model
could not omit those fields. The fix tracks which properties were not
originally required and injects nullability into their type (e.g.
`"string"` becomes `["string", "null"]`), allowing the model to send
`null` to signal omission.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

40 of 46 new or added lines in 2 files covered. (86.96%)

1 existing line in 1 file now uncovered.

22649 of 35275 relevant lines covered (64.21%)

214.97 hits per line