dcdpr / jp / 24500490563

67%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(storage, workspace, cli): Implement layered storage backend (#543)

Replace `Workspace`'s `Option<Storage>` with four non-optional trait
objects — `PersistBackend`, `LoadBackend`, `LockBackend`, and
`SessionBackend` — eliminating pervasive `Option` branching throughout
the workspace layer.

The root problem was that at least 15 methods on `Workspace` branched on
`self.storage.as_ref()`, yielding three different failure modes for the
same underlying condition: some silently no-oped, others returned
errors, and others returned `None`. A `disable_persistence` boolean
added a third dimension of optionality, and `ConversationMut` carried an
`Option<writer>` that callers could not inspect.

The new `jp_storage::backend` module introduces:

- `FsStorageBackend` — wraps `Storage`, implements all four traits, and
retains filesystem-specific path accessors (`storage_path`,
`user_storage_path`) outside the trait surface.
- `InMemoryStorageBackend` — fully in-memory implementation for tests
and future non-filesystem environments.
- `NullPersistBackend` — silently discards all writes; used for
`--no-persist` and error-path persistence suppression.
- `NoopLockGuard` — a no-op `ConversationLockGuard` for contexts where
real locking is not needed.

`Workspace` now holds `persist`, `loader`, `locker`, and `sessions` as
always-present trait objects. `Workspace::new` initialises them with
`NullPersistBackend` + `InMemoryStorageBackend`; callers opt into
filesystem storage by calling `with_backend(fs)`. The old builder chain
`Workspace::new(root).persisted_at(&storage)?.with_local_storage()?` is
replaced by constructing `FsStorageBackend` first, then passing it in.
`disable_persistence()` retains its signature but now swaps the
`persist` field for `NullPersistBackend` instead of flipping a boolean.

`ConversationLock` and `ConversationMut` lose their internal
optionality: `writer` and `lock_guard` are always present. The `if let
Some(writer)` branches in `flush`... (continued)

Coverage Stats

470 of 631 new or added lines in 24 files covered. (74.48%)

13 existing lines in 6 files now uncovered.

22588 of 35212 relevant lines covered (64.15%)

197.49 hits per line