systemd / systemd / 24485253600

73%

Build Type

push

github

Committed by daandemeyer

Commit Message

sd-varlink: Don't log successful sentinel error dispatch as a failure

sd_varlink_error() deliberately returns a negative errno mapped from
the error id on success so callbacks can `return sd_varlink_error(...);`
to enqueue the reply and propagate a matching errno at once. When
varlink_dispatch_method() dispatches a configured error sentinel itself,
it doesn't need that mapping — but it was treating any negative return
as a dispatch failure and logging "Failed to process sentinel" even
though the error reply had been successfully enqueued.

Detect success via the state transition to VARLINK_PROCESSED_METHOD
instead, so only genuine enqueue failures are logged.

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

3562 existing lines in 60 files now uncovered.

320532 of 445978 relevant lines covered (71.87%)

1180593.02 hits per line